Introduce suspenders:production:environment generator
#1151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crackofdusk
force-pushed
the
suspenders-3-0-0-production-env-generator
branch
from
1aaf935
to
acb443f
Compare
|
Noting we might want to set: |
jho406
reviewed
Mar 25, 2024
test/generators/suspenders/production_environment_generator_test.rb
Outdated
Show resolved
Hide resolved
jho406
reviewed
Mar 25, 2024
test/generators/suspenders/production_environment_generator_test.rb
Outdated
Show resolved
Hide resolved
stevepolitodesign
force-pushed
the
suspenders-3-0-0-production-env-generator
branch
from
acb443f
to
9bef3a6
Compare
stevepolitodesign
changed the title
suspenders:production_environment generatorsuspenders:production:environment generator
stevepolitodesign
requested review from
stevepolitodesign and
thiagoa
as code owners
stevepolitodesign
force-pushed
the
suspenders-3-0-0-production-env-generator
branch
from
9bef3a6
to
c22a177
Compare
Creates generator to configuration the production environment. For now, this means [requiring a master key][master key]. Drops configuration for [asset_host][], since that should be an infrastructure decision. In an effort to distinguish between the development environment configuration in #1149, we use the `production` namespace. [master key]: https://guides.rubyonrails.org/configuring.html#config-require-master-key [asset_host]: https://guides.rubyonrails.org/configuring.html#config-asset-host
stevepolitodesign
force-pushed
the
suspenders-3-0-0-production-env-generator
branch
from
c22a177
to
1476279
Compare
mike-burns
approved these changes
Apr 5, 2024
stevepolitodesign
added a commit
that referenced
this pull request
May 10, 2024
Creates generator to configuration the production environment. For now, this means [requiring a master key][master key]. Drops configuration for [asset_host][], since that should be an infrastructure decision. In an effort to distinguish between the development environment configuration in #1149, we use the `production` namespace. [master key]: https://guides.rubyonrails.org/configuring.html#config-require-master-key [asset_host]: https://guides.rubyonrails.org/configuring.html#config-asset-host Co-authored-by: Steve Polito <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates generator to configuration the production environment. For now,
this means requiring a master key.
Drops configuration for asset_host, since that should be an
infrastructure decision.
In an effort to distinguish between the development environment
configuration in #1149, we use the
productionnamespace.